Re: [PATCH v2 2/2] Makefile: pass -Wno-pendantic under GENERATE_COMPILATION_DATABASE=yes
From: Junio C Hamano <hidden>
Date: 2021-09-23 21:33:38
Ævar Arnfjörð Bjarmason [off-list ref] writes:
quoted hunk
The same bug fixed in the "COMPUTE_HEADER_DEPENDENCIES=auto" mode in the preceding commit was also present with "GENERATE_COMPILATION_DATABASE=yes". Let's fix it so it works again with "DEVOPTS=1". Signed-off-by: Ævar Arnfjörð Bjarmason <redacted> --- Makefile | 1 + 1 file changed, 1 insertion(+)diff --git a/Makefile b/Makefile index 10ea12aae21..94b116d4b37 100644 --- a/Makefile +++ b/Makefile@@ -1304,6 +1304,7 @@ endif ifeq ($(GENERATE_COMPILATION_DATABASE),yes) compdb_check = $(shell $(CC) $(ALL_CFLAGS) \ + -Wno-pedantic \
Yup, I like reusing the same approach from the other fix; removing $(ALL_CFLAGS) may work fine, too, and that is what I already queued, but I may swap it out with this later (if I do not forget, that is).
-c -MJ /dev/null \ -x c /dev/null -o /dev/null 2>&1; \ echo $$?)