Thread (7 messages) 7 messages, 3 authors, 2021-09-25

Re: [PATCH] doc/technical: remove outdated MIDX default note

flat view

From: Derrick Stolee <hidden>
Date: 2021-09-23 13:47:07

On 9/22/2021 6:13 PM, Eric Wong wrote:
Multi-pack-index files are used by default since
commit 18e449f86b74bab35b150549c8342d252fe7ae00, so the
outdated note was misleading.
You are correct that the note is misleading, but it is still correct.

A user can _disable_ reading MIDX files by setting core.multiPackIndex
to false. If this was in the user-facing docs, not the technical docs,
then I might push back on trying to make that distinction.
-- The core.multiPackIndex config setting must be on to consume MIDX files.
-
As it is, this deletion is fine.

A nit on your commit message: format commit references like this:

  18e449f86 (midx: enable core.multiPackIndex by default, 2020-09-25)

Thanks,
-Stolee
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help