Re: [PATCH v6 2/2] pretty: colorize pattern matches in commit messages

On Mon, Sep 20, 2021 at 10:38:10PM -0400, Hamza Mahfooz wrote:

On Mon, Sep 20 2021 at 09:39:27 PM -0400, Jeff King [off-list ref] wrote:

quoted

Here are two patches I prepared on top of your series to show what's
possible, though I think we should do one of:

  - put them at the front of your series (with the appropriate
    adjustments) as preparatory cleanup

  - keep them separate. You can put a comment above the cast to mention
    what's going on and why it's OK for now, and then later when they're
    both merged, we can remove that cast.

Option 1 is preferable from my perspective, in that case.

OK. The patches I showed were the minimum to get your series working,
but there's actually a bit more cleanup we can do. I'll post a new
series in a moment, and then you can build on top of that.

-Peff