Re: [PATCH 2/2] request-pull: mark translatable strings
From: Đoàn Trần Công Danh <hidden>
Date: 2021-09-16 13:44:33
Beside the problems pointed out by Ævar: On 2021-09-16 18:35:17+0700, Bagas Sanjaya [off-list ref] wrote:
Mark user-faced strings as translatable (including PR message output).
I would argue request-pull message shouldn't be translated. The person who creates the request may prefer to use a different language, let's say French, for day-to-day work. However, the recipients may not understand French, and prefer to receive English message. And this change break their workflow badly.
quoted hunk ↗ jump to hunk
@@ -138,19 +138,22 @@ fi url=$(git ls-remote --get-url "$url") -git show -s --format='The following changes since commit %H: +git show -s --format=" +$(gettext 'The following changes since commit %H: %s (%ci) are available in the Git repository at: -' $merge_base && +')
Hence, I think this message shouldn't be translated.
+" $merge_base && echo " $url $pretty_remote" && -git show -s --format=' +git show -s --format=" +$(gettext ' for you to fetch changes up to %H: %s (%ci)
And neither should this message.
quoted hunk ↗ jump to hunk
-----------------------------------------------------------------' $headrev && +----------------------------------------------------------------')" $headrev && if test $(git cat-file -t "$head") = tag then@@ -162,7 +165,7 @@ fi && if test -n "$branch_name" then - echo "(from the branch description for $branch_name local branch)" + echo "$(eval_gettext "(from the branch description for \$branch_name local branch)")" echo git config "branch.$branch_name.description" echo "----------------------------------------------------------------"
Ditto. -- Danh