Thread (2 messages) flat view 2 messages, 2 authors, 2021-09-13

Re: [PATCH] refs/files-backend: remove unused open mode parameter

From: Han-Wen Nienhuys <hidden>
Date: 2021-09-13 10:12:17

On Thu, Sep 9, 2021 at 11:46 PM René Scharfe [off-list ref] wrote:
We only need to provide a mode if we are willing to let open(2) create
the file, which is not the case here, so drop the unnecessary parameter.
I was #today years old when I learned that C supports (a limited form
of) function signature overloading.

LGTM

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--
Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help