Re: [PATCH v3 3/6] parse-options: stop supporting "" in the usagestr array
From: Junio C Hamano <hidden>
Date: 2021-09-12 22:26:50
Ævar Arnfjörð Bjarmason [off-list ref] writes:
quoted hunk
diff --git a/t/t0040-parse-options.sh b/t/t0040-parse-options.sh index ad4746d899a..2910874ece5 100755 --- a/t/t0040-parse-options.sh +++ b/t/t0040-parse-options.sh@@ -10,8 +10,6 @@ test_description='our own option parser' cat >expect <<\EOF usage: test-tool parse-options <options> - A helper function for the parse-options API. - --yes get a boolean -D, --no-doubt begins with 'no-' -B, --no-fear be brave
Isn't this, and a lot more importantly the next one ...
quoted hunk
diff --git a/t/t1502-rev-parse-parseopt.sh b/t/t1502-rev-parse-parseopt.sh index b29563fc997..6badc650d64 100755 --- a/t/t1502-rev-parse-parseopt.sh +++ b/t/t1502-rev-parse-parseopt.sh@@ -6,8 +6,6 @@ test_description='test git rev-parse --parseopt' test_expect_success 'setup optionspec' ' sed -e "s/^|//" >optionspec <<\EOF |some-command [options] <args>... -| -|some-command does foo and bar! |-- |h,help show the help |
... coalmine canaries that tell us that end-user's scripts using the "git rev-parse --parseopt" in the documented way will be broken? I'd rather not have to sorry about breaking end-user scripts this way. Unlike a very small number of in-tree parse_options() call in C programs, we have unbounded of them.