[PATCH] strvec: use size_t to store nr and alloc · Jeff King <hidden> · 2021-09-11
Re: [PATCH] strvec: use size_t to store nr and alloc · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-11
Re: [PATCH] strvec: use size_t to store nr and alloc · Philip Oakley <hidden> · 2021-09-11
[PATCH v2 0/7] strvec: use size_t to store nr and alloc · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-12
[PATCH v2 1/7] remote-curl: pass "struct strvec *" instead of int/char ** pair · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-12
Re: [PATCH v2 1/7] remote-curl: pass "struct strvec *" instead of int/char ** pair · Carlo Arenas <hidden> · 2021-09-12
Re: [PATCH v2 1/7] remote-curl: pass "struct strvec *" instead of int/char ** pair · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-13
[PATCH v2 2/7] pack-objects: pass "struct strvec *" instead of int/char ** pair · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-12
[PATCH v2 3/7] sequencer.[ch]: pass "struct strvec *" instead of int/char ** pair · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-12
[PATCH v2 4/7] upload-pack.c: pass "struct strvec *" instead of int/char ** pair · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-12
[PATCH v2 5/7] rebase: don't have loop over "struct strvec" depend on signed "nr" · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-12
Re: [PATCH v2 5/7] rebase: don't have loop over "struct strvec" depend on signed "nr" · Eric Sunshine <hidden> · 2021-09-12
[PATCH v2 6/7] strvec: use size_t to store nr and alloc · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-12
[PATCH v2 7/7] strvec API users: change some "int" tracking "nr" to "size_t" · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-12
Re: [PATCH v2 7/7] strvec API users: change some "int" tracking "nr" to "size_t" · Eric Sunshine <hidden> · 2021-09-12
Re: [PATCH v2 0/7] strvec: use size_t to store nr and alloc · Jeff King <hidden> · 2021-09-12
Re: [PATCH v2 0/7] strvec: use size_t to store nr and alloc · Junio C Hamano <hidden> · 2021-09-13
Re: [PATCH v2 0/7] strvec: use size_t to store nr and alloc · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-13
Re: [PATCH v2 0/7] strvec: use size_t to store nr and alloc · Jeff King <hidden> · 2021-09-13
Re: [PATCH v2 0/7] strvec: use size_t to store nr and alloc · Philip Oakley <hidden> · 2021-09-13
Re: [PATCH] strvec: use size_t to store nr and alloc · Jeff King <hidden> · 2021-09-12
Re: [PATCH] strvec: use size_t to store nr and alloc · Philip Oakley <hidden> · 2021-09-13
Re: [PATCH] strvec: use size_t to store nr and alloc · Jeff King <hidden> · 2021-09-12

Re: [PATCH v2 1/7] remote-curl: pass "struct strvec *" instead of int/char ** pair

From: Carlo Arenas <hidden>
Date: 2021-09-12 00:36:36

On Sat, Sep 11, 2021 at 5:16 PM Ævar Arnfjörð Bjarmason
[off-list ref] wrote:

We'll be changing the "int nr" in the "struct strvec" to "int size_t"

Did you mean "size_t nr"?

quoted hunk ↗ jump to hunk

-static int push_git(struct discovery *heads, int nr_spec, const char **specs)
+static int push_git(struct discovery *heads, struct strvec *specs)
 {
        struct rpc_state rpc;
-       int i, err;
+       int i;

you are already splitting them, why not then change 'i' also to be a size_t?

Carlo

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help