Re: [PATCH v2 3/5] help tests: add test for --config output
From: Junio C Hamano <hidden>
Date: 2021-09-11 01:33:10
Ævar Arnfjörð Bjarmason [off-list ref] writes:
quoted hunk ↗ jump to hunk
Add a missing test for checking what the --config output added in ac68a93fd2 (help: add --config to list all available config, 2018-05-26) looks like. We should not be emitting anything except config variables and the brief usage information at the end here. Signed-off-by: Ævar Arnfjörð Bjarmason <redacted> --- t/t0012-help.sh | 13 +++++++++++++ 1 file changed, 13 insertions(+)diff --git a/t/t0012-help.sh b/t/t0012-help.sh index c3aa016fd30..595bf81f133 100755 --- a/t/t0012-help.sh +++ b/t/t0012-help.sh@@ -77,6 +77,19 @@ test_expect_success 'git help -g' ' test_i18ngrep "^ tutorial " help.output ' +test_expect_success 'git help -c' ' + git help -c >help.output && + cat >expect <<-\EOF && + + '"'"'git help config'"'"' for more information
'\''git help config'\'' for more information is a tad shorter.
+ EOF + grep -v -E \ + -e "^[^.]+\.[^.]+$" \ + -e "^[^.]+\.[^.]+\.[^.]+$" \
I have to question if there is much value in this test, especially the latter pattern. A configuration variable with three-level name can have any byte, including a dot, in its second level, so rejecting a name with more than three dots in it can over-filter, depending on what new keys we'll document in the future.
+ help.output >actual && + test_cmp expect actual +' + test_expect_success 'generate builtin list' ' git --list-cmds=builtins >builtins '