Re: [PATCH 4/5] rebase -i: don't fork git checkout

Hi Philippe,

On Thu, 9 Sep 2021, Philippe Blain wrote:

Le 2021-09-09 à 06:53, Johannes Schindelin a écrit :

quoted

On Wed, 8 Sep 2021, Philippe Blain wrote:

quoted

Anyway, I'm not saying that we should not do what this patch is
proposing, but I think caveats such as that should be documented in the
commit message, and maybe an audit of other configs that might results
in behavioural differences should be done.

Since this is already a bug in the `apply` backend, it would be even
better to follow-up with a fix, hint, hint, nudge, nudge ;-)

I'm not sure I understand what you are saying. The fact that 'rebase'
does not pay attention to 'submodule.recurse' is not a bug in my opinion,
it's just a limitation of the current code... Or do you mean something else?

I must have misunderstood you. I thought you were saying that Phillip's
patch introduces the regression where `submodule.recurse` is no longer
respected.

Ciao,
Dscho