Re: [PATCH 03/11] t3407: use test_cmp_rev

From
Ævar Arnfjörð Bjarmason <hidden>
Date
2021-09-08 10:41:10
Reply to
Phillip Wood via GitGitGadget, 2021-09-08
On Wed, Sep 08 2021, Phillip Wood via GitGitGadget wrote:
quoted hunk ↗ jump to hunk
@@ -54,9 +54,9 @@ testrebase() {
 		echo d >> a &&
 		git add a &&
 		test_must_fail git rebase --continue &&
-		test $(git rev-parse HEAD) != $(git rev-parse main) &&
+		! test_cmp_rev HEAD main &&
Use "test_cmp_rev !", making the shell do the negation is troublesome
for the same reason we don't do it with git command, it potentially
hides segfaults (and that test helper invokes "git", hence the optional
"!" first rgument).
Thread (47 messages) 47 messages, 6 authors, last reply 2021-09-24
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help