Thread (44 messages) 44 messages, 3 authors, 2021-09-17
STALE1838d

Revision v1 of 3 in this series.

Revisions (3)
  1. v1 current
  2. v2 [diff vs current]
  3. v3 [diff vs current]

[PATCH 0/4] pack-bitmap: permute existing namehash values

From: Taylor Blau <hidden>
Date: 2021-09-07 21:17:55

This short series depends on tb/multi-pack-bitmaps and is used to propagate
the hashcache between .bitmap files when generating multi-pack reachability
bitmaps.

The gist is that single pack bitmaps get the namehash values via the traversal
used to generate the pack, but there is no such traversal for MIDX bitmaps, and
thus the hash-cache extension (if we were to write it) would contain all zeros.

This series teaches the pack-bitmap code how to permute the hashcache values
from an existing bitmap into the new one. This doesn't keep the hashcache
up-to-date, but it at least prevents existing data from falling out when
generating a MIDX bitmap.

Taylor Blau (4):
  t/helper/test-bitmap.c: add 'dump-hashes' mode
  pack-bitmap.c: propagate namehash values from existing bitmaps
  midx.c: respect 'pack.writeBitmapHashcache' when writing bitmaps
  t5326: test propagating hashcache values

 Documentation/config/pack.txt |  4 ++++
 builtin/multi-pack-index.c    | 21 ++++++++++++++++++++
 midx.c                        |  6 +++++-
 midx.h                        |  1 +
 pack-bitmap.c                 | 36 +++++++++++++++++++++++++++++------
 pack-bitmap.h                 |  1 +
 t/helper/test-bitmap.c        | 10 +++++++++-
 t/t5326-multi-pack-bitmaps.sh | 32 +++++++++++++++++++++++++++++++
 8 files changed, 103 insertions(+), 8 deletions(-)

-- 
2.33.0.96.g73915697e6
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help