Thread (122 messages) flat view 122 messages, 5 authors, 2022-02-17

Re: [PATCH 06/13] submodule: move core cmd_update() logic to C

From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2021-09-07 12:43:35

On Tue, Sep 07 2021, Atharva Raykar wrote:
 struct init_cb {
 	const char *prefix;
+	const char *superprefix;
 	unsigned int flags;
 };
-#define INIT_CB_INIT { NULL, 0 }
+#define INIT_CB_INIT { NULL, NULL, 0 }
Since you're doing some cleanup while you're at it, just changing this
in some earlier step to:

    define INIT_CB_INIT { 0 }

Is better, i.e. the NULL-ing out is implicit here. I have an unsubmitted
series that does that across the codebase.
+	.references = STRING_LIST_INIT_DUP, \
We do inits here, and append, but it seems nothing clears this string_list.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help