Thread (38 messages) 38 messages, 6 authors, 2021-10-14

Re: [PATCH v3 0/4] cache parent project's gitdir in submodules

flat view

From: Matheus Tavares Bernardino <hidden>
Date: 2021-09-04 17:50:46

Hi, Emily

On Thu, Aug 19, 2021 at 5:10 PM Emily Shaffer [off-list ref] wrote:
Emily Shaffer (4):
  t7400-submodule-basic: modernize inspect() helper
  introduce submodule.superprojectGitDir record
  submodule: record superproject gitdir during absorbgitdirs
  submodule: record superproject gitdir during 'update'
I left a few comments on patches 2 and 3. They are mostly about things
we have already discussed on the Review Club, but I got the chance to
experiment with the code a bit more after that, and I thought it could
be helpful to provide these inline suggestions. Hope it helps, and
thanks for the series!

Thanks,
Matheus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help