Re: [PATCH 1/3] fixup! refs: RFC: Reftable support for git-core
From: Han-Wen Nienhuys <hidden>
Date: 2021-09-02 09:26:15
On Thu, Sep 2, 2021 at 11:05 AM Jeff King [off-list ref] wrote:
On Wed, Sep 01, 2021 at 10:30:21PM -0700, Carlo Marcelo Arenas Belón wrote:quoted
need to reorder the variables to hopefully make it easier to see why they might not be used since assert will compile out itself with -DNDEBUG.This should probably lead with the reason for the patch (avoiding errors with NDEBUG), and then mention any other bits (like "we also reorder for clarity"). That makes the point of the patch easier to see.
Counterpoint: I can see what the problem is (thanks, Carlo!) but would likely fix it in a different way, so effort spent in polishing commit messages will be wasted. -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado