Re: [PATCH v4] pull, fetch: fix segfault in --set-upstream option

Started by Junio C Hamano on Sep 1, 2021

open the first message on its own page

Ævar Arnfjörð Bjarmason [off-list ref] writes:
quoted
If we all agree that die() is a better action, that must be done
now, or it will become never once the change is released to the
field.
Because someone might have been relying on the current behavior of
segfaulting to stop their script? And a mere warning() would break
things for them by having the script "work" if this patch were to make
it into a release?
No, because someone WILL start rely on the warning() behaviour,
expecting that the "fixed" command will now run to completion
without exiting with non-zero status.  Once that happens, it will
become impossible to flip it to die().
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help