Thread (4 messages) 4 messages, 3 authors, 2021-09-01

Re: [PATCH] gc: remove trailing dot from "gc.log" line

From: Eric Sunshine <hidden>
Date: 2021-08-31 18:24:09

Possibly related (same subject, not in this thread)

On Tue, Aug 31, 2021 at 2:18 PM Junio C Hamano [off-list ref] wrote:
Eric Sunshine [off-list ref] writes:
quoted
On Tue, Aug 31, 2021 at 10:37 AM Ævar Arnfjörð Bjarmason
[off-list ref] wrote:
quoted
                warning(_("The last gc run reported the following. "
                               "Please correct the root cause\n"
-                              "and remove %s.\n"
+                              "and remove %s\n"
Even more bikeshedding:

    Please correct the root cause and remove
    /path/to/repo/.git/gc.log
    to allow automatic cleanup to resume.

or something.
I also found the line break before "and remove" strange, but I think
that is because the "Please" is not at the beginning of the
paragraph, but is a second sentence.  Perhaps unfolding "and remove"
would make the first line overly long?
Yep, you're right, and perhaps my "Even more bikeshedding" didn't
clearly indicate that I was bikeshedding more about combining the
"Please correct..." and "Automatic cleanup..." sentences into a single
sentence, both as a another way to deal with the punctuation issue
(thus allowing easy double-click) and to make the whole thing read a
bit better.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help