On Mon, Aug 30, 2021 at 02:16:04PM -0400, Jeff King wrote:
On Mon, Aug 30, 2021 at 07:11:49PM +0300, Kirill A. Shutemov wrote:
quoted
I've stepped on a problem after upgrading git to v2.33.0. git fetch-pack
fails with an error:
fetch-pack: unexpected disconnect while reading sideband packet
It only happens when I access git.kernel.org over git:// (github over
git:// works fine) and if there's a gitproxy configured.
For test I used a dummy gitproxy:
#!/bin/sh -efu
socat - "TCP:$1:$2"
It is enough to trigger the issue.
I'm not sure if it's kernel.org problem or git problem.
Has anybody else stepped on the issue? Any clues?
I can't reproduce the problem here, using core.gitproxy with a script
identical to what you showed above. I tried both cloning, and fetching
via both git-fetch and git-fetch-pack.
Could you try with a kernel repo?
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
I found that not all repos on kernel.org trigger the issue.
Can you show us a more complete example? What does the command that
fails look like? What's the repo state before you run it? At what part
of the conversation does it fail (before a pack is sent, during, or
after)?
The last I see sent to the server is "packfile". It is consistent with the
bisected commit. Removing close() in do_fetch_pack_v2() helps.
If you can reproduce it at will and it fails on 2.33 but not earlier,
then bisecting might be helpful.
I did. See my other mail.
--
Kirill A. Shutemov