Thread (9 messages) read the whole thread 9 messages, 2 authors, 2021-08-30

Re: [RFC PATCH v2 0/2] suppress trailing whitespace on empty "notes" lines

From: Eric Sunshine <hidden>
Date: 2021-08-30 16:50:15

On Mon, Aug 30, 2021 at 12:45 PM Eric Sunshine [off-list ref] wrote:
It probably won't surprise you that this fix to `notes` started out as
a single patch which made the change to `notes.c` and adjusted the
existing tests to account for it. In particular, my original changes
to t3301 were exactly the same changes you made (i.e. merely dropping
the empty-line `${indent}` from the few necessary places). I wasn't
happy about the additional complexity I had to add to t3303 and t9301
to continue plucking the notes out of the default git-log output, thus
simplified by making those tests less brittle. That, of course,
deserved its own patch. I wavered quite a bit about whether to make
t3301 less brittle too, or to simply apply the minimal changes which I
had already made (and which you made independently). Eventually, I
decided to split that out as a brittle-fixing patch, as well, to
better future-proof it, but perhaps that's terribly important.
...that's NOT terribly important.

(last-second editing mistake strikes again)
I don't have strong feelings between my v1 and your v2 of this series,
and would be happy to see Junio pick up either version.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help