Thread (2 messages) flat view 2 messages, 2 authors, 2021-08-30

Re: [PATCH] t5582: remove spurious 'cd "$D"' line

From: Junio C Hamano <hidden>
Date: 2021-08-30 16:42:10

Possibly related (same subject, not in this thread)

SZEDER Gábor [off-list ref] writes:
On Wed, Aug 25, 2021 at 09:12:37AM -0700, Junio C Hamano wrote:
quoted
Jeff King [off-list ref] writes:
quoted
Hmm. I think that one is different, in that the "cd" is not redundant,
but wrong. But it turns out not to matter to the test. ;)
Funny. 

We are lucky because 'cd ""' stays in the same repository as the
current one and not to a random place,
Actually, the results of 'cd ""' are unspecified, though most shells
do as you said.  Do we want something like this?
I doubt it, as the root issue is not "cd" but "$D" and other
variables that we use before setting.

I wonder how close our test suite is for being "set -u" clean.
Running our tests under "set -u" may not be a bad endpoint, but
only if we can get there without too much pain.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help