Re: [PATCH 2/2] make: delete strip target
From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2021-08-26 19:36:53
On Thu, Aug 26 2021, Bagas Sanjaya wrote:
quoted hunk ↗ jump to hunk
The target isn't needed anymore since stripping is done in install-strip target (in previous patch). Signed-off-by: Bagas Sanjaya <redacted> --- Makefile | 2 -- 1 file changed, 2 deletions(-)diff --git a/Makefile b/Makefile index b8a3a64422..027b052a0c 100644 --- a/Makefile +++ b/Makefile@@ -2170,8 +2170,6 @@ please_set_SHELL_PATH_to_a_more_modern_shell: shell_compatibility_test: please_set_SHELL_PATH_to_a_more_modern_shell -strip: $(PROGRAMS) git$X - $(STRIP) $(STRIP_OPTS) $^ ### Flags affecting all rules
This doesn't remove the phony "strip" target (nor does the first patch), and in any case I think this would be more readable with the two patches squashed together. Let's remove the old target & add the new one atomically.