Re: [PATCH RESEND] branch: allow deleting dangling branches with --force

Am 26.08.21 um 09:26 schrieb Han-Wen Nienhuys:

On Wed, Aug 25, 2021 at 11:37 PM Junio C Hamano [off-list ref] wrote:

quoted

quoted

+test_expect_success 'branch --delete --force removes dangling branch' '
+     test_when_finished "rm -f .git/refs/heads/dangling" &&
+     echo $ZERO_OID >.git/refs/heads/dangling &&
+     git branch --delete --force dangling &&
+     test_path_is_missing .git/refs/heads/dangling
+'

This goes against the spirit of the series merged at c9780bb2 (Merge
branch 'hn/prep-tests-for-reftable', 2021-07-13).

I assume the file backend won't go away anytime soon.  So I guess the
idea is that the test suite is supposed to be run with the new backend
as default and exercise it?

quoted

Can we creat the dangling ref and test the lack of "dangling" ref in
the end in a less transparent way?

agreed. Try the ref-store test-helper's update-ref command?

It requires the new hash to refer to an existing object, so we can't
use it in this test.

René