Thread (73 messages) flat view 73 messages, 7 authors, 2021-08-31
STALE1852d

Revision v1 of 3 in this series.

Revisions (3)
  1. v1 current
  2. v2 [diff vs current]
  3. v3 [diff vs current]

[PATCH 1/6] tr2: remove NEEDSWORK comment for "non-procfs" implementations

From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2021-08-25 23:19:56
Subsystem: the rest · Maintainer: Linus Torvalds

I'm fairly sure that there is no way on Linux to inspect the process
tree without using procfs, any tool such as ps(1), top(1) etc. that
shows this sort of information ultimately looks the information up in
procfs.

So let's remove this comment added in 2f732bf15e6 (tr2: log parent
process name, 2021-07-21), it's setting us up for an impossible task.

Signed-off-by: Ævar Arnfjörð Bjarmason <redacted>
---
 compat/linux/procinfo.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/compat/linux/procinfo.c b/compat/linux/procinfo.c
index 578fed4cd31..15a89676c7a 100644
--- a/compat/linux/procinfo.c
+++ b/compat/linux/procinfo.c
@@ -25,7 +25,6 @@ static void get_ancestry_names(struct strvec *names)
 	}
 
 	return;
-	/* NEEDSWORK: add non-procfs-linux implementations here */
 }
 
 void trace2_collect_process_info(enum trace2_process_info_reason reason)
-- 
2.33.0.733.ga72a4f1c2e1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help