Thread (1 message) 1 message, 1 author, 2021-08-23

Re: [PATCH v7 2/3] maintenance: `git maintenance run` learned `--scheduler=<scheduler>`

From: Junio C Hamano <hidden>
Date: 2021-08-23 22:30:18

Lénaïc Huard [off-list ref] writes:
Is the suggestion to replace

+#ifdef __APPLE__
+	return 1;
+#else
+	return 0;
+#endif
+}

by

+ return IS_LAUNCHCTL_AVAILABLE;

and to add

#ifdef __APPLE__
#define IS_LAUNCHCTL_AVAILABLE 1
#else
#define IS_LAUNCHCTL_AVAILABLE 0
#endif

somewhere else like at the top of builtin/gc.c ?
I wasn't the one who suggested it, but the suggestion reads as such
to me.
Also, do we agree this shouldn’t be defined in cache.h ? I’m a little bit 
confused.
The audience of "cache.h" (or more precisely, "git-compat-util.h" is
where these come from by including system headers) is much wider
than those narrow users who care about launchtrl or cron, so
limiting it in builtin/gc.c would make more sense, I would think.

Thanks.


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help