Re: What's cooking in git.git (Aug 2021, #06; Mon, 16)

On Tue, Aug 17, 2021 at 1:13 PM Derrick Stolee [off-list ref] wrote:

On 8/17/2021 12:47 PM, Junio C Hamano wrote:

quoted

Phillip Wood [off-list ref] writes:

quoted

quoted

* lh/systemd-timers (2021-07-02) 3 commits
  Waiting for reviews.

I'd really like to see this merged, there was some discussion a couple
of weeks ago (cf [ref]), it
petered out but no one seemed to be objecting to merging it.

Thanks for paying attention to this item.

My impression was that everybody likes the ability to use systemd
timers as an alternative to cron, but as Derrick summarised in the
message you pointed at, I think the implementation is not quite
there.

So "Waiting for reviews" is a mislabel; we are waiting for a reroll.

I think a lot of our comments were "We would hold an established
contributor to a higher standard, but this is sufficient for a new
contributor. The rest can be forward-fixed." We also have not heard
from the original contributor since that discussion.

Yes, this summarizes the situation well. I gave v6 a thorough
readthrough and although I found a single minor test-time bug -- which
Lénaïc addressed in v7 -- there were no show-stoppers at all. Although
there may be a few warts in v7 (such as non-ASCII comment blocks) they
are minor and can be addressed by follow-on patches (from anyone who
steps up, not necessarily Lénaïc who, as a relative newcomer, has
patiently re-rolled repeatedly).

Perhaps enough time has passed that we can expect Lénaïc will not
get back to us, I could give an attempt to forward-fix the comments
with a patch series on top of these. We could then hold
lh/systemd-timers in 'next' (or even 'seen') until it can be joined
with those fixes.

If preferred, I could restart the series by inserting some patches
and editing some of the ones in the list currently.

That would be nice. It would be good to see this series land.