Thread (1 message) 1 message, 1 author, 2021-08-17

Re: [PATCH] ci: add job for gcc-4.8 to GitHub Actions

From: Junio C Hamano <hidden>
Date: 2021-08-17 19:36:11

SZEDER Gábor [off-list ref] writes:
quoted
IMHO it may be more trouble than it's worth. If we can't find a compiler
that complains on this construct, then maybe it is not a construct worth
worrying too much about.
Absolutely.  Of course, there are vendor compilers that are not GNU
or clang that may throw us surprises ;-)
I for one like for loop initial declarations, because they allow us to
limit the scope of the loop variable to the loop, and would love to
see it used in more places (well, wherever possible, actually, but
that'd be a lot of churn).  So I would prefer to just drop this job
sooner rather than later, update CodingGuidelines, and, if deemed
necessary, launch a weather balloon.
I'd agree in general, but it must be done in a bit different order,
i.e. weather balloon first.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help