RE: [PATCH v5] clone: set submodule.recurse=true if user enables feature.experimental flag
From: Felipe Contreras <hidden>
Date: 2021-08-13 17:33:48
Mahi Kolla via GitGitGadget wrote:
From: Mahi Kolla <redacted>
quoted hunk ↗ jump to hunk
--- a/builtin/clone.c +++ b/builtin/clone.c@@ -986,6 +986,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix) struct remote *remote; int err = 0, complete_refs_before_fetch = 1; int submodule_progress; + int experimental_flag; struct transport_ls_refs_options transport_ls_refs_options = TRANSPORT_LS_REFS_OPTIONS_INIT;@@ -1130,6 +1131,11 @@ int cmd_clone(int argc, const char **argv, const char *prefix) strbuf_detach(&sb, NULL)); } + if(!git_config_get_bool("feature.experimental", &experimental_flag) &&
You are missing a space after the 'if'.
+ experimental_flag) {
+ string_list_append(&option_config, "submodule.recurse=true");
+ }
+-- Felipe Contreras