Thread (4 messages) flat view 4 messages, 3 authors, 2021-08-12

Re: [PATCH v1 1/1] list-objects.c: traverse_trees_and_blobs: rename and tree-wide

From: Teng Long <hidden>
Date: 2021-08-12 08:05:54

quoted
FWIW, I was about reply and suggest the exact same name. :)

As something internal to list-objects.c, I don't think it matters all
that much either way. The name "traverse_commit_list()" is IMHO more
likely to confuse. It is public within the project, and of course
traverses any type of object. So "traverse_objects()" or something may
be more accurate.
On the basis of understanding the relationship between git objects,
`traverse_commit_list` is understandable, for me.
quoted
OTOH I do not find it all that confusing, and it may not be worth the
disruption to the code base.
Agree.

It’s interesting to read your reply, because of learning a lot of
abbreviations.

Thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help