Re: [GSoC] [PATCH v5 1/9] submodule--helper: add options for compute_submodule_clone_url()

Bagas Sanjaya [off-list ref] writes:

On 10/08/21 18.46, Atharva Raykar wrote:

quoted

  	if (git_config_get_string(remotesb.buf, &remoteurl)) {
-		warning(_("could not look up configuration '%s'. Assuming this repository is its own authoritative upstream."), remotesb.buf);
+		if (!quiet)
+			warning(_("could not look up configuration '%s'. "
+				  "Assuming this repository is its own "
+				  "authoritative upstream."),
+				remotesb.buf);
  		remoteurl = xgetcwd();
  	}

Why did you split warning message? We could keep that in one line.

That line was too long, and given that I was moving the function and
changing it a little bit, I decided to make it adhere more closely to
the CodingGuidelines [1] and local convention.

[1] https://github.com/git/git/blob/6c85aac65fb455af85745130ce35ddae4678db84/Documentation/CodingGuidelines#L190