Re: [PATCH/RFC 3/3] ci: run a pedantic build as part of the GitHub workflow
flat view
From: Bagas Sanjaya <hidden>
Date: 2021-08-09 10:50:42
On 09/08/21 08.38, Carlo Marcelo Arenas Belón wrote:
similar to the recently added sparse task, it is nice to know as early as possible. add a dockerized build using fedora (that usually has the latest gcc) to be ahead of the curve and avoid older ISO C issues at the same time.
But from GCC manual [1], the default C dialect used is `-std=gnu17`, while `-pedantic` is only relevant for ISO C (such as `-std=c17`). And why not using `-pedantic-errors`, so that non-ISO features are treated as errors? Newcomers contributing to Git may think that based on what our CI do, they can submit patches with C17 features (perhaps with GNU extensions). Then at some time there is casual users that complain that Git doesn't compile with their default older compiler (maybe they run LTS distributions or pre-C17 compiler). Thus we want Git to be compiled successfully using wide variety of compilers (maybe as old as GCC 4.8). [1]: https://gcc.gnu.org/onlinedocs/gcc-11.2.0/gcc/Standards.html#Standards -- An old man doll... just what I always wanted! - Clara