Re: [PATCH] makefile: update detect-compiler for newer Xcode version
From: Atharva Raykar <hidden>
Date: 2021-08-06 13:42:51
Carlo Marcelo Arenas Belón [off-list ref] writes:
1da1580e4c (Makefile: detect compiler and enable more warnings in DEVELOPER=1, 2018-04-14) uses the output of the compiler banner to detect the compiler family. Apple had since changed the wording used to refer to its compiler as clang instead of LLVM as shown by: $ cc --version Apple clang version 12.0.5 (clang-1205.0.22.9) Target: x86_64-apple-darwin20.6.0 Thread model: posix InstalledDir: /Library/Developer/CommandLineTools/usr/bin so update the script to match, and allow DEVELOPER=1 to work as expected again in macOS.
Thanks for submitting this enhancement! For those of us using Homebrew and using the LLVM installation from there, we get: $ cc --version Homebrew clang version 12.0.1 Target: arm64-apple-darwin20.5.0 Thread model: posix InstalledDir: /opt/homebrew/opt/llvm/bin
quoted hunk ↗ jump to hunk
Signed-off-by: Carlo Marcelo Arenas Belón <redacted> --- detect-compiler | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/detect-compiler b/detect-compiler index 70b754481c..c85be83c64 100755 --- a/detect-compiler +++ b/detect-compiler@@ -44,7 +44,7 @@ clang) "FreeBSD clang") print_flags clang ;; -"Apple LLVM") +"Apple LLVM"|"Apple clang") print_flags clang ;; *)
So maybe we could add another case for "Homebrew clang"? --- Atharva Raykar ಅಥರ್ವ ರಾಯ್ಕರ್ अथर्व रायकर