Re: [GSoC] [PATCH v2 2/9] submodule--helper: refactor resolve_relative_url() helper

Atharva Raykar [off-list ref] writes:

Refactor the helper function to resolve a relative url, by reusing the
existing `compute_submodule_clone_url()` function.

`compute_submodule_clone_url()` performs the same work that
`resolve_relative_url()` is doing, so we eliminate this code repetition
by moving the former function's definition up, and calling it inside
`resolve_relative_url()`.

Looking good.

Signed-off-by: Atharva Raykar <redacted>
Mentored-by: Christian Couder [off-list ref]
Mentored-by: Shourya Shukla [off-list ref]
---
 builtin/submodule--helper.c | 61 +++++++++++++++----------------------
 1 file changed, 25 insertions(+), 36 deletions(-)

This step is easier to see with "show --patience --color-moved" to
see that compute_submodule_clone_url() has only been moved without
any change.  And the actual change is much smaller than what the
diffstat suggests above (11 lines lost, 1 line updated, if I counted
correctly).

Nicely done.