Thread (31 messages) 31 messages, 4 authors, 2021-08-23
STALE1862d

Revision v1 of 2 in this series.

Revisions (2)
  1. v1 current
  2. v2 [diff vs current]

[PATCH v1 1/4] advice: add a function to set the value of an advice type

From: Ben Boeckel <hidden>
Date: 2021-07-31 02:25:17
Subsystem: the rest · Maintainer: Linus Torvalds

This is setup for removing the `advice` global variables.

Signed-off-by: Ben Boeckel <redacted>
---
 advice.c | 5 +++++
 advice.h | 5 +++++
 2 files changed, 10 insertions(+)
diff --git a/advice.c b/advice.c
index 0b9c89c48a..fd58631dc1 100644
--- a/advice.c
+++ b/advice.c
@@ -187,6 +187,11 @@ int advice_enabled(enum advice_type type)
 	}
 }
 
+void advice_set(enum advice_type type, int value)
+{
+	advice_setting[type].enabled = value;
+}
+
 void advise_if_enabled(enum advice_type type, const char *advice, ...)
 {
 	va_list params;
diff --git a/advice.h b/advice.h
index bd26c385d0..74425a9f1a 100644
--- a/advice.h
+++ b/advice.h
@@ -87,6 +87,11 @@ void advise(const char *advice, ...);
  */
 int advice_enabled(enum advice_type type);
 
+/**
+ * Enable or disable advice of a certain kind.
+ */
+void advice_set(enum advice_type type, int value);
+
 /**
  * Checks the visibility of the advice before printing.
  */
-- 
2.31.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help