Thread (35 messages) flat view 35 messages, 4 authors, 2021-07-30
STALE1878d

Revision v2 of 3 in this series.

Revisions (3)
  1. v1 [diff vs current]
  2. v2 current
  3. v3 [diff vs current]

[PATCH v2 5/5] add: remove ensure_full_index() with --renormalize

From: Derrick Stolee via GitGitGadget <hidden>
Date: 2021-07-26 15:19:17
Subsystem: the rest · Maintainer: Linus Torvalds

From: Derrick Stolee <redacted>

The --renormalize option updates the EOL conversions for the tracked
files. However, the loop already ignores files marked with the
SKIP_WORKTREE bit, so it will continue to do so with a sparse index
because the sparse directory entries also have this bit set.

Signed-off-by: Derrick Stolee <redacted>
---
 builtin/add.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/builtin/add.c b/builtin/add.c
index d512ece655b..c49e179abc3 100644
--- a/builtin/add.c
+++ b/builtin/add.c
@@ -144,8 +144,6 @@ static int renormalize_tracked_files(const struct pathspec *pathspec, int flags)
 {
 	int i, retval = 0;
 
-	/* TODO: audit for interaction with sparse-index. */
-	ensure_full_index(&the_index);
 	for (i = 0; i < active_nr; i++) {
 		struct cache_entry *ce = active_cache[i];
 
-- 
gitgitgadget
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help