Re: [PATCH 1/2] bundle tests: use ">file" not ": >file"
From: Junio C Hamano <hidden>
Date: 2021-07-20 19:58:03
Ævar Arnfjörð Bjarmason [off-list ref] writes:
Change redundant uses of ":" on the LHS of a ">" to the more commonly
While the changes are correct, I am not sure if the adjective "redundant" would apply. The word refers to uses of two or more when one would suffice, but in this case, you use one explicit no-op command ":" when you need zero.
use ">file" pattern.
"use" -> "used".
quoted hunk
Signed-off-by: Ævar Arnfjörð Bjarmason <redacted> --- t/t5607-clone-bundle.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/t/t5607-clone-bundle.sh b/t/t5607-clone-bundle.sh index f4c383cd5ce..c9323a08fe8 100755 --- a/t/t5607-clone-bundle.sh +++ b/t/t5607-clone-bundle.sh@@ -54,14 +54,14 @@ test_expect_success 'bundle --stdin <rev-list options>' ' ' test_expect_success 'empty bundle file is rejected' ' - : >empty-bundle && + >empty-bundle && test_must_fail git fetch empty-bundle ' # This triggers a bug in older versions where the resulting line (with # --pretty=oneline) was longer than a 1024-char buffer. test_expect_success 'ridiculously long subject in boundary' ' - : >file4 && + >file4 && test_tick && git add file4 && printf "%01200d\n" 0 | git commit -F - &&@@ -75,7 +75,7 @@ test_expect_success 'ridiculously long subject in boundary' ' ' test_expect_success 'prerequisites with an empty commit message' ' - : >file1 && + >file1 && git add file1 && test_tick && git commit --allow-empty-message -m "" &&