Thread (6 messages) flat view 6 messages, 3 authors, 2021-07-19

Re: [GSoC] My Git Dev Blog – Week 8

From: Kaartic Sivaraam <hidden>
Date: 2021-07-18 17:40:05

Hi Atharva,

On 13/07/21 2:16 pm, Atharva Raykar wrote:
I was seeing if it was possible to at least save another spawn for calling
init when '--init' is provided for an update. The current implementation
does not spawn a separate process for this, so I was hoping I don't add
more overhead in the conversion, but it's looking hard to avoid at the
moment.
I'm having some difficulties understanding this. I tried to take a look
at the existing code[2][3] in 'git-submodule.sh', I could only see that
if '--init' is passed to update, it calls the 'cmd_update' shell function
which in turn does invoke 'git submodule--helper init'. OTOH, if '--recursive'
is passed 'cmd_update' itself is called recursively called after setting
the 'prefix' and 'wt_prefix' shell variables.

So, I'm not sure how you mean to say that a sub-process was not spawned
when '--init' is passed. Could you clarify this a little?
quoted
[1]: https://public-inbox.org/git/20180205235508.216277-1-sbeller@google.com/
[2]: https://github.com/git/git/blob/abb21c7263616f01c5e950861a29279ab21cb02f/git-submodule.sh#L530-L533

[3]: https://github.com/git/git/blob/abb21c7263616f01c5e950861a29279ab21cb02f/git-submodule.sh#L651-L673

-- 
Sivaraam
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help