RE: [PATCH 4/9] pull: since --ff-only overrides, handle it first

From
Felipe Contreras <hidden>
Date
2021-07-17 18:22:41
Reply to
Elijah Newren via GitGitGadget, 2021-07-17
Elijah Newren via GitGitGadget wrote:
From: Elijah Newren <redacted>

There are both merge and rebase branches in the logic, and previously
both had to handle fast-forwarding.  Merge handled that implicitly
(because git merge handles it directly), while in rebase it was
explicit.  Given that the --ff-only flag is meant to override any
--rebase or --no-rebase, make the code reflect that by handling
--ff-only before the merge-vs-rebase logic.

No functional changes, just making it easier to verify that the codeflow
matches our precedence rules.
But it does have a functional changes. Now you are calling run_merge()
without update_submodules().

-- 
Felipe Contreras
Thread (44 messages) 44 messages, 3 authors, last reply 2021-07-22
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help