Thread (20 messages) 20 messages, 2 authors, 2021-07-17

Re: [PATCH v4 0/3] worktree: teach add to accept --reason with --lock

From: Eric Sunshine <hidden>
Date: 2021-07-17 00:15:12

On Thu, Jul 15, 2021 at 1:17 PM Eric Sunshine [off-list ref] wrote:
On Wed, Jul 14, 2021 at 10:32 PM Stephen Manz via GitGitGadget
[off-list ref] wrote:
quoted
Changes since v3:

 * Updated test to define a shell variable, lock_reason, set to "why not".
   Expand the variable to use with --reason and to echo to file, expected.
   This avoids the spacing comment made by Eric Sunshine.
Thanks, these changes look fine to me. I don't know whether or not
Junio has merged this series down to his "next" branch yet locally,
though. If he has, then he may not pick up your v4, and this minor
cleanup change could instead be done as a standalone patch atop v3 (or
could be dropped since v3 was probably "good enough").
It looks like Junio did pick up v4, so no need for a standalone
cleanup patch atop v3.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help