Re: [PATCH 3/3] diff: correct warning message when renameLimit exceeded

On Mon, Jul 12, 2021 at 8:09 AM Derrick Stolee [off-list ref] wrote:

On 7/10/2021 8:46 PM, Elijah Newren via GitGitGadget wrote:

quoted

From: Elijah Newren <redacted>

The warning when quadratic rename detection was skipped referred to
"inexact rename detection".  For years, the only linear portion of
rename detection was looking for exact renames, so "inexact rename
detection" was an accurate way to refer to the quadratic portion of
rename detection.  However, that changed with commit bd24aa2f97a0
(diffcore-rename: guide inexact rename detection based on basenames,
2021-02-14), so now the correct way to refer to quadratic rename
detection is "quadratic rename detection".  Fix the warning accordingly.

Now that I read this more specific reason for using "quadratic", my
earlier comments on patch 1 are slightly less helpful. Specifically,
I was recommending to continue using "inexact renames" but that is
not 100% true anymore.

I still think this "quadratic rename detection" is perhaps hard to
parse as a non-expert. This subtlety of some "easy" inexact renames
definitely makes the definition harder.

Since the steps that find inexact renames without the quadratic
algorithm are heuristics, perhaps this portion could instead be
called "exhaustive rename detection" or even "expensive rename
detection"? It perhaps implies more directly that the limit exists
as a way to prevent an expensive operation.

The name "exhaustive rename detection" seems reasonable to me.  I'll
resubmit using that term and see what folks think.