Thread (135 messages) flat view 135 messages, 4 authors, 2021-08-23
STALE1860d

[PATCH v6? 17/17] refs API: don't leak "errno" in run_transaction_hook()

From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2021-07-11 16:31:06
Subsystem: the rest · Maintainer: Linus Torvalds

In run_transaction_hook() we've checked errno since 67541597670 (refs:
implement reference transaction hook, 2020-06-19), let's reset errno
afterwards to make sure nobody using refs.c directly or indirectly
relies on it.

Signed-off-by: Ævar Arnfjörð Bjarmason <redacted>
---
 refs.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/refs.c b/refs.c
index 3357ba14e1d..f1477eed27a 100644
--- a/refs.c
+++ b/refs.c
@@ -2108,8 +2108,11 @@ static int run_transaction_hook(struct ref_transaction *transaction,
 			    update->refname);
 
 		if (write_in_full(proc.in, buf.buf, buf.len) < 0) {
-			if (errno != EPIPE)
+			if (errno != EPIPE) {
+				/* Don't leak errno outside this API */
+				errno = 0;
 				ret = -1;
+			}
 			break;
 		}
 	}
-- 
2.32.0-dev
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help