Hi Atharva,


On 10 ஜூலை, 2021 பிற்பகல் 1:22:16 IST, Atharva Raykar [off-list ref] wrote:

quoted

On 09-Jul-2021, at 20:22, Đoàn Trần Công Danh [off-list ref]

wrote:

quoted

On 2021-07-08 15:25:31+0530, Atharva Raykar [off-list ref]

wrote:

quoted

quoted

The standard `die()` function that is used in C code prefixes all

the

quoted

quoted

messages passed to it with 'fatal: '. This does not happen with the
`die` used in 'git-submodule.sh'.

Let's prefix each of the shell die messages with 'fatal: ' so that

when

quoted

quoted

they are converted to C code, the error messages stay the same as

before

quoted

quoted

the conversion.

That sounds good.

quoted

--- a/git-submodule.sh
+++ b/git-submodule.sh

@@ -147,7 +147,7 @@ cmd_add()

	if ! git submodule--helper config --check-writeable >/dev/null 2>&1
	then
-		 die "$(eval_gettext "please make sure that the .gitmodules file

is in the working tree")"

quoted

quoted

+		 die "$(eval_gettext "fatal: please make sure that the

.gitmodules file is in the working tree")"

quoted

Except that, "fatal: " isn't subjected to translation. And this will
create new translatable item for translator. Perhaps:

-		 die "$(eval_gettext "please make sure that the .gitmodules file

is in the working tree")"

quoted

+		 die "fatal: $(eval_gettext "please make sure that the .gitmodules

file is in the working tree")"

Okay, I have made the change. I was wondering if there any specific
reason as to why 'fatal' should not be translated? Is it because
an intermediate change like this should not create more work for
translators? 

Yes. That's likely the intention.

-- 
Sivaraam

Sent from my Android device with K-9 Mail. Please excuse my brevity.