Thread (1 message) 1 message, 1 author, 2021-07-08

Re: [GSoC] [PATCH v2 2/4] submodule: prefix die messages with 'fatal'

From: Junio C Hamano <hidden>
Date: 2021-07-08 15:17:56

Atharva Raykar [off-list ref] writes:
The standard `die()` function that is used in C code prefixes all the
messages passed to it with 'fatal: '. This does not happen with the
`die` used in 'git-submodule.sh'.

Let's prefix each of the shell die messages with 'fatal: ' so that when
they are converted to C code, the error messages stay the same as before
the conversion.
Sounds good.  More importantly, the error messages from the
resulting system would become more uniform---after all, the end
users would not care if scripted part of the system is emitting the
error messages, or the message comes from a built-in version.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help