Elijah Newren wrote:

On Sat, Jun 26, 2021 at 9:16 PM Felipe Contreras
[off-list ref] wrote:

quoted

Elijah Newren wrote:

quoted

The code changes look good, but you'll need to add several test
changes as well, or this code change will cause test failures.

Wouldn't you consider sending a patch without running 'make test'
"cavalier"?

quoted

Thanks for working on this.

Such a completely different tone for a "cavalier" patch depending 100%
on the person who sent it. Weird.

First of all, attacking a random bystander like Alex is rather
uncalled for.

I did not attack Alex, I simply pointed out the fact that his patch
breaks the test suite, which you did too.

I asked *you* if you didn't consider this "cavalier". Your reaction
seems inconsistent. This question has nothing to do with Alex.

I don't throw personal attacks, nor do I chastise contributors for
attempting to improve the project. That's your department.

I focus on the ball, not the player.

-- 
Felipe Contreras