Re: [PATCH 2/2] pull: improve default warning
From: Felipe Contreras <hidden>
Date: 2021-06-23 04:18:11
Elijah Newren wrote:
On Tue, Jun 22, 2021 at 2:22 PM Alex Henrie [off-list ref] wrote:quoted
On Tue, Jun 22, 2021 at 9:06 AM Elijah Newren [off-list ref] wrote:quoted
On Mon, Jun 21, 2021 at 8:15 PM Alex Henrie [off-list ref] wrote:quoted
My only serious objection to this patch is the instruction to merge if you don't know what to do instead of asking the repository maintainer what to do or reading the Git documentation. I don't have a strong opinion on the rest of the patch.You're not alone, Alex; I objected to that part as well. (See e.g. https://lore.kernel.org/git/CABPp-BF4rXBOKsn8bG6y3QUEtNVV9K2Pk5NmwrU5818CqhRt_Q@mail.gmail.com/ (local) and various other emails in that thread, ending with "agree to disagree" later). I still object to it as I did then.Thanks for the link, and sorry for not having followed this conversation closely enough to have seen your previous replies. WhileNo worries, you were trying to be a good citizen by reviewing patches, and the patches didn't come with links to the old threads
That's not true. This patch series [1] came with a link to the previous patch series [2]. I didn't, cannot, and shouldn't contain hundreds of links to the hundres of responses to this topic over the past 10 years. [1] https://lore.kernel.org/git/20210621175234.1079004-1-felipe.contreras@gmail.com/ (local) [2] https://lore.kernel.org/git/20201218211026.1937168-1-felipe.contreras@gmail.com/ (local) -- Felipe Contreras