Re: [PATCH 2/3] Makefile: stop hardcoding {command,config}-list.h

On Thu, Jun 17 2021, Felipe Contreras wrote:

Ævar Arnfjörð Bjarmason wrote:

quoted

On Thu, Jun 17 2021, Felipe Contreras wrote:

quoted

Ævar Arnfjörð Bjarmason wrote:

quoted

Change various places that hardcode the names of these two files to
refer to either $(GENERATED_H), or to a new generated-hdrs
target.

Avoiding hard-coded things is generally a good idea, and I can smell
there's an advantage nearby, but it's not stated.

Can you spell out what you are trying to achieve?

It's hinted at in the CL,

Yes, but the commit message should stand on its own.

quoted

but this is series 1/3 of a re-roll of the
base topic for config-based hooks, real use of this is made in step 2/3,
3/3 has a better overview:
http://lore.kernel.org/git/cover-00.27-0000000000-20210617T101216Z-avarab@gmail.com (local)

Yeah, I read the cover letter afterwards, but I'm just putting my
reviewer cap; the rationale belongs in the commit message: we will want
more generated files in GENERATED_H.

Thanks, I'll reword it. I initially figured in this case it was better
not to distract from a stand-alone change with what inspired it, but
will do.

Also, I presume you meant this one:
https://lore.kernel.org/git/cover-0.3-0000000000-20210617T100239Z-avarab@gmail.com/ (local)

That's 2/3, but yes. That comes after this one. I meant to link to 3/3
to give the general overview of how this relates to that re-rolled topic
at large.