Thread (16 messages) 16 messages, 3 authors, 2021-06-17

RE: [PATCH v2 0/4] show-branch: add missing tests, trivial color output change

flat view

From: Felipe Contreras <hidden>
Date: 2021-06-17 21:46:59

Ævar Arnfjörð Bjarmason wrote:
This v2 doesn't change any of the code (see range-diff), but better
explains the change per Michael J Gruber's feedback in
https://lore.kernel.org/git/162374905722.40525.516266574605586007.git@grubix.eu/ (local)

There's also a trivial grammar fix, s/add/odd/g.

Ævar Arnfjörð Bjarmason (4):
  show-branch tests: rename the one "show-branch" test file
  show-branch tests: modernize test code
  show-branch: don't <COLOR></RESET> for space characters
  show-branch tests: add missing tests
All these look good to me (I would prefer patch #2 to be split into
multiple patches, but that's not a deal-breaker).

Reviewed-by: Felipe Contreras <redacted>

-- 
Felipe Contreras
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help