RE: [PATCH v2 1/5] test-lib-functions: introduce test_line_count_cmd
From: Felipe Contreras <hidden>
Date: 2021-06-17 04:51:43
Đoàn Trần Công Danh wrote:
In Git project,
In _the_ Git project
we have multiple occasions that requires checking number
multiple instances that require checking the number
of lines of text in stdout and/or stderr of a command. One of such example is t6400,
One of such examples
which checks number of files in various states.
that checks the number of files (see 'that' vs. 'which' [1]).
Some of those commands are Git command,
are git commands,
and we would like to check their exit status. In some of those checks, we pipe the stdout of those commands to "wc -l" to check for line count,
for a line count,
thus loosing the exit status.
losing
Introduce a helper function to check for number of lines in stdout and
the number of lines
stderr from those commands. This helper will create 2 temporary files in process,
the process
thus it may affect output of some checks.
the output
quoted hunk ↗ jump to hunk
Signed-off-by: Đoàn Trần Công Danh <redacted> --- t/test-lib-functions.sh | 117 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 117 insertions(+)diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh index f0448daa74..b3281409de 100644 --- a/t/test-lib-functions.sh +++ b/t/test-lib-functions.sh@@ -845,6 +845,123 @@ test_line_count () { fi } +# test_line_count_cmd checks exit status,
the exit status
and the number of lines in
+# captured stdout and/or stderr of a command.
the captured stdout...
quoted hunk ↗ jump to hunk
+# +# Usage: +# +# test_line_count_cmd [--[out|err] <binop> <value>]... [--] [!] cmd [args...] +# +# Options: +# --out <binop> <value>: +# --err <binop> <value>: +# Run sh's "test <# of lines> <binop> <value>" on # of lines in stdout +# (for --out) or stderr (for --err) +# !: +# Instead of expecting "cmd [args...]" succeed, expect its failure. +# Note, if command under testing is "git",
the command under...
test_must_fail should be used
quoted hunk ↗ jump to hunk
+# instead of "!". +# +# Example: +# test_line_count_cmd --out -ge 10 --err = 0 git tag --no-contains v1.0.0 +# test_line_count_cmd --out -le 10 ! grep some-text a-file +# test_line_count_cmd --out = 0 test_must_fail git rev-parse --verify abcd1234 +# +# NOTE: +# * if "--out" is specified, a temporary file named test_line_count_cmd_.out +# will be created. +# * if "--err" is specified, a temporary file named test_line_count_cmd_.err +# will be created. +# Those temporary files will be created under $TRASH_DIRECTORY/.git/trash +# if $TRASH_DIRECTORY/.git directory existed.
if $TRASH_DIRECTORY/.git/ exists
+# Otherwise, they will be created in $TRASH_DIRECTORY. +# Those temporary files will be cleant by test_when_finished
will be cleaned by ... Cheers. [1] https://www.merriam-webster.com/words-at-play/when-to-use-that-and-which -- Felipe Contreras