Re: [PATCH] test-lib: fix "$remove_trash" regression and match_pattern_list() bugs
From: Junio C Hamano <hidden>
Date: 2021-06-16 09:22:17
Possibly related (same subject, not in this thread)
- 2021-06-17 · Re: [PATCH] test-lib: fix "$remove_trash" regression and match_pattern_list() bugs · Junio C Hamano <hidden>
- 2021-06-17 · Re: [PATCH] test-lib: fix "$remove_trash" regression and match_pattern_list() bugs · Junio C Hamano <hidden>
- 2021-06-16 · Re: [PATCH] test-lib: fix "$remove_trash" regression and match_pattern_list() bugs · Jeff King <hidden>
- 2021-06-16 · Re: [PATCH] test-lib: fix "$remove_trash" regression and match_pattern_list() bugs · Ævar Arnfjörð Bjarmason <hidden>
- 2021-06-16 · Re: [PATCH] test-lib: fix "$remove_trash" regression and match_pattern_list() bugs · Jeff King <hidden>
Jeff King [off-list ref] writes:
... Still, I kind of like the "set -f" version because it doesn't need the extra directory which could cause problems with "ls-files -o", etc, as you mentioned. You could also create the empty directory on the fly, though if "set -f" works portably, that seems less complicated to me.
FWIW, I share that.