Thread (5 messages) flat view 5 messages, 3 authors, 2021-06-15

Re: [PATCH v2 3/4] sideband: append suffix for message whose CR in next pktline

From: Jiang Xin <hidden>
Date: 2021-06-15 02:57:21

Junio C Hamano [off-list ref] 于2021年6月15日周二 上午9:17写道:
Jiang Xin [off-list ref] writes:
quoted
    /*
     * Let's insert a suffix to clear the end
     * of the screen line, but only if current
     * line data actually contains something.
     */

So my implementation is to try not to break the original
implementation, and keep the linelen unchanged.
I knew what you wanted to do from your code---I am questioning if
that "only when something is there" was really sensible, or if it
was just attracting bugs.
@Nicolas, what's your opinion? Is it ok to add clear-to-eol suffix to
each line even empty ones?

--
Jiang Xin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help