Re: [PATCH v2] *: fix typos which duplicate a word
From: Andrei Rybak <hidden>
Date: 2021-06-11 09:32:42
On 11/06/2021 01:59, Junio C Hamano wrote:
Andrei Rybak [off-list ref] writes:quoted
Fix typos in documentation and code comments which repeat various words.Thanks.quoted
These typos were found by searching using scripts like this: for w in $(grep '^....$' /usr/share/dict/words) do git grep -P "\b$w $w\b" doneThis is clarifying and somewhat puzzling at the same time. It says that doubled words that span across line folding, and doubled words that do not have exactly a single space in between, have gone undetected (which is fine and may be useful information) by showing that it grepped for lines that has doubled words. But it also says that you only looked for four-letter words, which I do not believe is the case (you fixed "the the", for example), which is misleading. The "like this" part can be an excuse for that
Indeed. Basically, it was several scripts with different lists of words. I considered writing: for w in <list of words> do git grep -P "\b$w $w\b" done but opted for an explicit example of a script used, which may be reused later.
inaccuracy, but then the whole thing pretty much has already been summarized nicely with your first line already, i.e. "which repeate various words". If you update it the end part of the sentence to "which repeat various words on the same line",
Since v2, I've written a script to also check sentences which span several lines. I'll send out a v3 with a bunch more fixes.
then the entire paragaph can go without losing clarity. Not a huge deal, though. The changes themselves all look good to me. Thanks. Will apply.