Re: [PATCH v2 2/4] promisor-remote: support per-repository config

Jonathan Tan [off-list ref] writes:

quoted

Instead of using global variables to store promisor remote information,
store this config in struct repository instead, and add
repository-agnostic non-static functions corresponding to the existing
non-static functions that only work on the_repository.

This does make sense.  In general, repository extensions are per
repository, so anything read from "extensions.*" should be stored
per in-core repository structure.

But doesn't that mean the thing that should be fixed is on the
setup.c side, where not just extensions.partialClone but other data
is read into "struct repository_format *format"?  Shouldn't we have
a pointer to that struct in the in-core repository object?

Special casing the "partialClone" field alone feels somewhat strange
to me.

Thanks.

My reply is the same as what I replied to the query in patch 1 [1].

[1] https://lore.kernel.org/git/20210609042649.2322758-1-jonathantanmy@google.com/ (local)